KX Community

Find answers, ask questions, and connect with our KX Community around the world.
KX Community Guidelines

Home Forums kdb+ First Project Attempt Reply To: First Project Attempt

  • choppergrip

    Member
    September 30, 2024 at 10:03 am

    It looks good, but the code style can be improved a bit:
    – consistency with semicolons, you have it after closing the bracket, but not for all functions
    – for “-1” messages it probably makes sense to have some wrapper function
    – possible arguments validation inside of the
    optimizePortfolio function
    – maybe you want to have these functions in a specific namespace to avoid clashes during import in bigger project
    – unit tests and integration test